Feature/change workdir #238
Merged
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR aims to set the container
WORKDIRon the image to a path not used in building stages that could be later mounted using ephemeral disks. The former path used is not suitable for the ephemeral volume mount mentioned since the building process persists data on it, and mounting an empty volume on this path would cause the container to lose the data required.This change also requires the Stellar core configuration path to be adjusted for commands where the CoreConfig is not passed as an argument since it is gotten from environment details and later set to paths relative to the container
WORKDIR.Key Changes
WORKDIRto/etl/datafrom/etlCoreConfigto refer to the absolute path instead of the relative path.